topology2: cavs-sdw: Add cs42l43 and cs35l56 support on ADL/RPL, MTL/ARL, LNL #9355
Conversation
|
@charleskeepax , @bardliao , @plbossart , As you discused in thesofproject/linux#5130 (comment) , it's better to add all corresponding topologies support mapping to acpi mach entries. I will update the patch. |
PLATFORM=tgl, can safely removed as it is not included in cavs-sdw and does not affect the soundwire configurations. Remove SDW_FMT_24 flag because it has become the fixed format for soundwire configurations. SDW_AMP_FEEDBACK is currently used for debugging purposes. So set false to disable it. Signed-off-by: Mac Chiang <mac.chiang@intel.com>
macchian
force-pushed
the
dev-arl-codec
branch
2 times, most recently
from
65304dd
to
1ef3efc
Compare
macchian
changed the title
| SDW_JACK_IN_STREAM=Capture-SimpleJack,SDW_AMP_FMT_24=true,SDW_JACK_FMT_24=true" | ||
| "cavs-sdw\;sof-tgl-cs42l43-l3-cs35l56-l01\;NUM_SDW_AMP_LINKS=2,SDW_DMIC=1,\ | ||
| SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,SDW_DMIC_STREAM=Capture-SmartMic,\ | ||
| SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack" |
There was a problem hiding this comment.
Why are we dropping the 24bit stuff here? I think we should probably add that on the other entries too, cs42l43 doesn't support 32-bits over the soundwire (not tried it, perhaps the extra bits just get ignored, but officially the hardware doesn't support) and also you will run out of soundwire bandwidth in a lot of configurations if sending 32-bit.
There was a problem hiding this comment.
Why are we dropping the 24bit stuff here? I think we should probably add that on the other entries too, cs42l43 doesn't support 32-bits over the soundwire (not tried it, perhaps the extra bits just get ignored, but officially the hardware doesn't support) and also you will run out of soundwire bandwidth in a lot of configurations if sending 32-bit.
After #9282 was merged, 24 bit is the default format for SoundWire. We don't need to set SDW_AMP_FMT_24 and SDW_JACK_FMT_24 anymore.
There was a problem hiding this comment.
ah I see missed that, thanks, in that case all looks good for me the other comment is so minor I wouldn't both to do a spin just for it.
| @@ -21,4 +21,18 @@ SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack" | |||
| # No SDW Jack. SDW DMIC+SPK | |||
| "cavs-sdw\;sof-lnl-rt1318-l12-rt714-l0\;PLATFORM=lnl,SDW_JACK=false,SDW_DMIC=1,\ | |||
| NUM_SDW_AMP_LINKS=2,SDW_DMIC_STREAM=SDW0-Capture" | |||
|
|
|||
| # SDW Bridge to SPK | |||
| "cavs-sdw\;sof-lnl-cs42l43-l0\;PLATFORM=lnl,SDW_DMIC=1,NUM_SDW_AMP_LINKS=1,\ | |||
There was a problem hiding this comment.
Minor nit but its a bit weird SDW_DMIC and NUM_SDW_AMP_LINKS is in a different order on this entry.
@macchian are we still pending on any items ? This looks ready to be non draft ? |
@lgirdwood, we are currently awaiting the codec verification results from the customer. I will provide an update as soon as the feedback is received. |
The ADL, ARL, LNL hardware board configurations are below:
ARL has the same dsp generiation as MTL. So set platform = mtl.
SoundWire#
├── link 0: cs42l43 Audio Jack and DMICs/Bridge to amplifiers.
| | -> sof-rpl-cs42l43-l0.tplg
│ │ -> sof-mtl-cs42l43-l0.tplg
│ │ -> sof-arl-cs42l43-l0.tplg
│ │ -> sof-lnl-cs42l43-l0.tplg
│ │
│ ├── link 2: cs35l56 Left and Right Amplifier.
│ -> sof-arl-cs42l43-l0-cs35l56-l2.tplg
│
├──── link 2: cs35l56 Right/Rightx2 Amplifier.
├──── link 3: cs35l56 Left/Leftx2 Amplifier.
-> sof-adl-cs42l43-l0-cs35l56-l23.tplg
-> sof-arl-cs42l43-l0-cs35l56-l23.tplg
-> sof-lnl-cs42l43-l0-cs35l56-l23.tplg
SoundWire#
├── link 2: cs42l43 Audio Jack and DMICs.
│ -> sof-arl-cs42l43-l2.tplg
│
├──── link 3: cs35l56 Left and Right Amplifier.
-> sof-arl-cs42l43-l2-cs35l56-l3.tplg
Signed-off-by: Mac Chiang <mac.chiang@intel.com>
macchian
force-pushed
the
dev-arl-codec
branch
from
1ef3efc
to
e140832
Compare
macchian
changed the title
SoundWire#
├── link 0: cs42l43 Audio Jack and DMICs/Bridge to amplifiers.
| | -> sof-rpl-cs42l43-l0.tplg
│ │ -> sof-mtl-cs42l43-l0.tplg
│ │ -> sof-arl-cs42l43-l0.tplg
│ │ -> sof-lnl-cs42l43-l0.tplg
│ │
│ ├── link 2: cs35l56 Left and Right Amplifier.
│ -> sof-arl-cs42l43-l0-cs35l56-l2.tplg
│
├──── link 2: cs35l56 Right/Rightx2 Amplifier.
├──── link 3: cs35l56 Left/Leftx2 Amplifier.
-> sof-adl-cs42l43-l0-cs35l56-l23.tplg
-> sof-arl-cs42l43-l0-cs35l56-l23.tplg
-> sof-lnl-cs42l43-l0-cs35l56-l23.tplg
SoundWire#
├── link 2: cs42l43 Audio Jack and DMICs.
│ -> sof-arl-cs42l43-l2.tplg
│
├──── link 3: cs35l56 Left and Right Amplifier.
-> sof-arl-cs42l43-l2-cs35l56-l3.tplg