Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: ace30: fix SOF log level #9359

Closed
wants to merge 1 commit into from
Closed

boards: ace30: fix SOF log level #9359

wants to merge 1 commit into from

Conversation

abonislawski
Copy link
Member

This will fix SOF logs build, previously INF log level was ON but at the same time log level OFF was ON

@abonislawski
boards: ace30: fix SOF log level
0de53d3 
This will fix SOF logs build,
previously INF log level was ON but at the same time log level OFF

Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
@kv2019i
Copy link
Collaborator

kv2019i commented Aug 13, 2024

@wszypelt @abonislawski Can you check the quickbuild fail, this would otherwise be good to merge now.

ujfalusi
ujfalusi requested changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@ujfalusi ujfalusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this for some reason breaks ssp0 loopback

@ujfalusi ujfalusi self-requested a review August 13, 2024 10:11
@lgirdwood
Copy link
Member

this for some reason breaks ssp0 loopback

Hmm, sounds like a race - have we isolated the "important" log messages needed for SSP yet ?

@kv2019i
Copy link
Collaborator

kv2019i commented Aug 26, 2024

@ujfalusi @abonislawski update on this?

ujfalusi
ujfalusi approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@ujfalusi ujfalusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kv2019i, yes, this is good, the issue was in other place and a coincident

@kv2019i
Copy link
Collaborator

kv2019i commented Aug 27, 2024

@wszypelt Can you check quickbuild?

@wszypelt
Copy link

wszypelt commented Aug 27, 2024 •
edited
Loading

@kv2019i quality issue in SRC at PTL_FPGA
test_01_04_src[24000-48000-32-2]
test_01_04_src[48000-16000-32-2]
Quality issues in 25% of audio: LowQuality (25% C1, 25% C2).
twice in a row

@kv2019i
Copy link
Collaborator

kv2019i commented Aug 27, 2024

Ack @wszypelt thank you. @dnikodem can you take a look at above? Could be a perf issue when logs are enabled, so maybe we need to keep logs disabled in the overlay for FPGA.

@lgirdwood lgirdwood added this to the v2.11 milestone Sep 2, 2024
@kv2019i kv2019i mentioned this pull request Sep 4, 2024
Merged
@kv2019i
Copy link
Collaborator

kv2019i commented Sep 5, 2024

Merged via #9436 instead.

@kv2019i kv2019i closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbernatxintel gbernatxintel gbernatxintel approved these changes

@marcinszkudlinski marcinszkudlinski marcinszkudlinski approved these changes

@dnikodem dnikodem dnikodem approved these changes

@kv2019i kv2019i kv2019i approved these changes

@ujfalusi ujfalusi ujfalusi approved these changes

@lgirdwood lgirdwood Awaiting requested review from lgirdwood lgirdwood is a code owner

@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner

@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 is a code owner

@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.11
Development

Successfully merging this pull request may close these issues.
8 participants
@abonislawski @kv2019i @lgirdwood @wszypelt @ujfalusi @dnikodem @marcinszkudlinski @gbernatxintel