-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zephyr: sof/lib/mm_heap.h added Zephyr version #9467
Conversation
@kv2019i some build errors:
|
The platform memory.c defines "sof->memory_map" which is used by the XTOS allocator code (sof/src/lib/alloc.c). The NXP Zephyr build targets no longer use this allocator, so the platform memory definitions are no longer needed. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Definitions of mm_heap.h interface are not needed in Zephyr builds. To avoid pulling in XTOS definitions when building with CONFIG_SOF_ZEPHYR_STRICT_HEADERS=n, add a no-op version for Zephyr. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
aaa3bcc
to
b643d10
Compare
@iuliana-prodan @dbaluta Can you check the nxp patch? I build tested and seems to be fine now (let's see if CI agrees). I didn't remove the file yet as at least one imx target was still using XTOS, but please check. |
Looks like most CI has run now and results look fine, just pending final CI reports. |
@lgirdwood let's wait for someone from @thesofproject/nxp to ack. This is not urgent PR and I can only build test on the nxp target, so I can wait for feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I'm aware platform_init_memmap()
is not used in Zephyr so including memory.c
in the build wasn't necessary. Anyways, thanks for the cleanup work you've been doing lately. Tested on imx8 with an aplay, no logs.
Definitions of mm_heap.h interface are not needed in Zephyr builds. To avoid pulling in XTOS definitions when building with CONFIG_SOF_ZEPHYR_STRICT_HEADERS=n, add a no-op version for Zephyr.