Add support for byte controls in the SOF plugin #9484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranj063
requested review from
singalsu,
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
singalsu
reviewed
Sep 18, 2024
lyakh
reviewed
Sep 18, 2024
This is necessary to pass the param ID for the data being requested. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Set the type while parsing the controls. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Parse and set up the kcontrols during topology parsing. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
It will be used by both the PCM and the control plugin. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
…on code It will be used by both the PCM and the control plugin. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Add a new field in struct plug_shm_ctl to save the bytes data from topology for bytes controls. This will be used to send the kcontrol data to the modules right after they are instantiated. Fix the tlv callback in the control to handle the tlv bytes read/write when using sof-ctl. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ranj063
force-pushed
the
fix/plugin_kcontrol
branch
from
4a03f2a
to
d5ea317
Compare
lgirdwood
approved these changes
Sep 19, 2024
singalsu
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.