Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio: Aria: Fix handling of S24_LE format, update blob ABI headers in topologies #9614

Merged
merged 6 commits into from
Oct 28, 2024

Commits on Oct 25, 2024

  1. Audio: Aria: Fix in generic C handling of S24_LE format

    The bits 31:24 are defined as don't care for S24_LE format
    while the code in functions aria_algo_calc_gain() and
    aria_algo_get_data() can work only if the bits contain the
    sign extension. If such data is received, the processed
    audio output is be corrupt.
    
    The generic C version is fixed with use of helper function
    sign_extend_s24().
    
    Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
    singalsu committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d5d21ab View commit details
    Browse the repository at this point in the history
  2. Audio: Aria: Fix in HiFi3 version S24_LE input data handling

    These changes implement the missing sign extension handling
    for input data. The highest 8 bits in S24_LE format are don't
    care. The presence of sign extension can't be assumed.
    
    The max of max_data can be moved out from while loop as a
    small improvement.
    
    Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
    singalsu committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    c538d33 View commit details
    Browse the repository at this point in the history
  3. Audio: Aria: Fix HiFi5 version S24_LE input data handling

    These changes implement the missing sign extension handling
    for input data. The highest 8 bits in S24_LE format are don't
    care. The presence of sign extension can't be assumed.
    
    The max of the two max values can be moved out from while
    loop as a small improvement.
    
    Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
    singalsu committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    98ae51c View commit details
    Browse the repository at this point in the history
  4. Audio: Aria: Update component description in kconfig

    The impact of parameter attenuation applied at aria_init()
    and in bytes control blob is explained in more clear way.
    
    Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
    singalsu committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    8cb87d9 View commit details
    Browse the repository at this point in the history
  5. Audio: Aria: Improve aria_set_config(), warn illegal blob

    It depends on architecture but size_t and uint32_t are not
    necessarily bits compatible (on 64bit arch like testbench
    on x86). Therefore the type for att in component data of
    Aria is changed to uint32_t.
    
    A similar check as in aria_init() is added to avoid an illegal
    value in the blob to break the processing algorithm.
    
    An info level trace is added to see in trace if the blob
    is applied by the Linux topology or in run-time.
    
    Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
    singalsu committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    81eb004 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Tools: Topology2: Update configuration blobs for Aria

    The blob for Aria is updated for current ABI version and
    with options for all possible configurations. The new blobs
    are passthrough.conf, and blobs for parameter values 1 - 3.
    The benchmark topologies are configured to to use parameter
    value 2 (+12 dB level boost target) and parameter value 1
    (+6 dB boost target).
    
    Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
    singalsu committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    6392107 View commit details
    Browse the repository at this point in the history