Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: intel_adsp_a*conf: continue cleanup of board files #9623

Conversation

kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented Oct 29, 2024

Use the template introduce in #9620 and apply this to all Intel board files. Series starts with fresh cleanups for cAVS2.5 and PTL, the a commt to align ACE1.5 to #9620 and a few minor fixes for problems (now much easier to see when the options are grouped like this).

Group the configuration options per theme, separate SOF and Zephyr
Kconfig settings and order the entries in alphabetical order within
each group. This makes the board config file much more readable and
easy to maintain. No functional change, only reordering the entries.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Group the configuration options per theme, separate SOF and Zephyr
Kconfig settings and order the entries in alphabetical order within
each group. This makes the board config file much more readable and
easy to maintain. No functional change, just reordering the options.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Group the configuration options per theme, separate SOF and Zephyr
Kconfig settings and order the entries in alphabetical order within
each group. This makes the board config file much more readable and

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Remove old, duplicated options for rimage signing schema from cavs25 and
cavs25_tgph config files. No functional change to build as the newer
options have taken precedence already before this change.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Continue the cleanup and separate SOF and Zephyr options in
the board config file. No functional change, just reordering
the options.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Move CONFIG_ZEPHYR_LOG to correct section under SOF logging
configuration as this option is not Zephyr but a SOF-side option,
despite what its name hints at.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kv2019i btw - do we need to state alpha order in a top level comment in each file ?

@kv2019i
Copy link
Collaborator Author

kv2019i commented Oct 30, 2024

@lgirdwood wrote:

btw - do we need to state alpha order in a top level comment in each file ?

A good idea, probably should have added this. I'll go ahead and merge this still as we got test+review pass and this is ready to go (and the board file changes are evasive).

@kv2019i kv2019i merged commit b5d78bb into thesofproject:main Oct 30, 2024
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants