-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
probe: Convert to module API #9629
Conversation
@jsarha kernel fix now merged - pls convert to non draft if ready. Btw, do we need any tooling changes ? |
Nope, the functionality has not changed. |
@jsarha can you check CI build results. Breaking Zephyr configs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Some build errors that need to get address before merge, but no blockers otherwise.
This commit converts probe debug feature from component to module API. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
b48943d
to
ec05d1d
Compare
The unused variable warning is now fixed, so compile test should be Ok. There is still some device test failures that hardly have anything to do with this PR (the probes are not used in CI tests AFAIK). |
sof-docs fail and Intel LNL fails all known and tracked in https://github.com/thesofproject/sof/issues?q=is%3Aissue+is%3Aopen+label%3ACI |
This commit converts probe debug feature from component to module API.
With this PR the probes does not work without this fix in the Linux side: thesofproject/linux#5221
So its maybe better to wait a bit before merging this? Or what do you say @lgirdwood ?