Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

probe: Convert to module API #9629

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

jsarha
Copy link
Contributor

@jsarha jsarha commented Oct 31, 2024

This commit converts probe debug feature from component to module API.

With this PR the probes does not work without this fix in the Linux side: thesofproject/linux#5221

So its maybe better to wait a bit before merging this? Or what do you say @lgirdwood ?

@lgirdwood
Copy link
Member

This commit converts probe debug feature from component to module API.

With this PR the probes does not work without this fix in the Linux side: thesofproject/linux#5221

So its maybe better to wait a bit before merging this? Or what do you say @lgirdwood ?

@jsarha kernel fix now merged - pls convert to non draft if ready. Btw, do we need any tooling changes ?

@jsarha
Copy link
Contributor Author

jsarha commented Oct 31, 2024

This commit converts probe debug feature from component to module API.
With this PR the probes does not work without this fix in the Linux side: thesofproject/linux#5221
So its maybe better to wait a bit before merging this? Or what do you say @lgirdwood ?

@jsarha kernel fix now merged - pls convert to non draft if ready. Btw, do we need any tooling changes ?

Nope, the functionality has not changed.

@jsarha jsarha marked this pull request as ready for review October 31, 2024 12:11
@lgirdwood
Copy link
Member

@jsarha can you check CI build results. Breaking Zephyr configs.

Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some build errors that need to get address before merge, but no blockers otherwise.

This commit converts probe debug feature from component to module API.

Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
@jsarha
Copy link
Contributor Author

jsarha commented Nov 4, 2024

Looks good. Some build errors that need to get address before merge, but no blockers otherwise.

The unused variable warning is now fixed, so compile test should be Ok. There is still some device test failures that hardly have anything to do with this PR (the probes are not used in CI tests AFAIK).

@kv2019i
Copy link
Collaborator

kv2019i commented Nov 4, 2024

sof-docs fail and Intel LNL fails all known and tracked in https://github.com/thesofproject/sof/issues?q=is%3Aissue+is%3Aopen+label%3ACI

@kv2019i kv2019i merged commit 53f2d96 into thesofproject:main Nov 4, 2024
43 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants