Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

challenge_submission #2

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

shivanishah269
Copy link

Extraction of frequency from log file and converting in order of GHz and then printing both the values.

@thesourcerer8
Copy link
Owner

I am getting many lines that say "Check input file again". Is that intentional? The input file looks good to me.

@thesourcerer8
Copy link
Owner

"Maximum frquency in GHz is: 174796.0 GHz" Now that would be really cool with CMOS! By the way, there is a typo in frquency.

@shivanishah269
Copy link
Author

I am getting many lines that say "Check input file again". Is that intentional? The input file looks good to me.
Sorry for this bug, it was not intentional.

"Maximum frquency in GHz is: 174796.0 GHz" Now that would be really cool with CMOS! By the way, there is a typo in frquency.
Ya, this was my silly mistake in conversion.

I have updated the file.

@shivanishah269 shivanishah269 changed the title challenge_1_2 challenge_submission Jun 16, 2020
@shivanishah269
Copy link
Author

I have updated challenge 3.

@thesourcerer8
Copy link
Owner

I think you are using the wrong rounding function for this application. Please check.

Ya correct.
@shivanishah269
Copy link
Author

I think you are using the wrong rounding function for this application. Please check.

Ya correct. We should the exact frequency if we change it will affect other constraints as well.

@thesourcerer8
Copy link
Owner

I think the "maximum frequency" could be rounded down, to avoid issues, but it must not be rounded up. I think more than 5 digits of precision is usually not needed, so I would suggest to round it down to 5 digits. (But what if we have an extremely slow circuit that only can do kilohertz? rounding down to 0 would be bad. So if rounding down would result in 0 we should allow arbitrary percision perhaps.

@shivanishah269
Copy link
Author

I think the "maximum frequency" could be rounded down, to avoid issues, but it must not be rounded up. I think more than 5 digits of precision is usually not needed, so I would suggest to round it down to 5 digits. (But what if we have an extremely slow circuit that only can do kilohertz? rounding down to 0 would be bad. So if rounding down would result in 0 we should allow arbitrary percision perhaps.

Ya correct. I have updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants