Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ru translation. #1228

Conversation

thewca-bot
Copy link
Contributor

Submitted by Oleg Gritsenko (WCA ID: 2011GRIT01, WCA Account ID: 140).

one: '%{count} соревнование'
few: '%{count} соревнования'
many: '%{count} соревнований'
other: '%{count} WTF'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL I just noticed this. @Claster, could you explain this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shouldn't be visible, because :other key is not used. We check it with Philippe:

(byebug) (0..100000).each { |c| if (I18n.t('toto.akey', count: c) == "other") then puts c end }
 0..100000

Here is the code, one can check that :other branch is never reached.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange. So is this a bug with @jonatanklosko's app that it's requiring you to enter these keys, even though they're not used? Or is it a bug with our local testing code?

Either way, this seems good to merge to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of it, probably a bug in rails-i18n, or some requirement to have "other" that we don't know of.
i18n-spec (that checks for missing pluralization keys), uses this set of keys for Russian too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for decimals probably, see svenfuchs/rails-i18n#703 (comment). In Polish I just copy other as it doesn't matter.

@jfly jfly merged commit ffee093 into thewca:master Jan 31, 2017
@jfly jfly added the i18n label Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants