Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platform/6914: Replacing shared read/write lock with an upgradeable, distinct read and write locking mechanism #10

Merged
merged 2 commits into from
Jun 13, 2024
Merged

platform/6914: Replacing shared read/write lock with an upgradeable, distinct read and write locking mechanism #10

merged 2 commits into from
Jun 13, 2024

Conversation

Ghnuberath
Copy link
Member

Related to thinkdata-works/platform#6914

@Ghnuberath Ghnuberath added the enhancement New feature or request label Jun 13, 2024
@Ghnuberath Ghnuberath self-assigned this Jun 13, 2024
ChrisSandison
ChrisSandison reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@ChrisSandison ChrisSandison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code contains panics. Should we have it return errors instead?

@Ghnuberath
Copy link
Member Author

This code contains panics. Should we have it return errors instead?

From what I can tell, the panics reflect only misuse of the library, so I'd leave them.

@ChrisSandison ChrisSandison merged commit 4d85a84 into main Jun 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisSandison ChrisSandison ChrisSandison approved these changes

Assignees

@Ghnuberath Ghnuberath

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ghnuberath @ChrisSandison