Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analysis suite #3

Merged
merged 47 commits into from
Jan 10, 2024
Merged

Add analysis suite #3

merged 47 commits into from
Jan 10, 2024

Conversation

thinker227
Copy link
Owner

Adds a suite of analyzers and corresponding code fixes. Want to add more in the future but this works as a minimum.

Copy link
Collaborator

@viceroypenguin viceroypenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me. I'd probably argue whitespace on some of it, but that's personal opinion, so I won't argue with what you got.

One recommendation: add to implicit usings using <Usings Include="" /> in the csproj instead of using GlobalUsings.cs.

Comment on lines +21 to +30
var location = operation.Syntax is InvocationExpressionSyntax
{
Expression: MemberAccessExpressionSyntax
{
Name: GenericNameSyntax
{
TypeArgumentList.Arguments: [var typeSyntax]
}
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this

@thinker227
Copy link
Owner Author

One recommendation: add to implicit usings using <Usings Include="" /> in the csproj instead of using GlobalUsings.cs.

I didn't know you could do this. I might do a pr to clean this up later, although for now I prefer keeping them in a Usings.cs file.

@thinker227 thinker227 merged commit 3eb0238 into main Jan 10, 2024
1 check passed
@thinker227 thinker227 deleted the analysis branch January 10, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants