React Native - Add Settings Stack #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noriega2112
force-pushed
the
feature/settings-stack
branch
from
f904b98
to
8d653d4
Compare
This commit updates the user API to support partial updates. It adds a new custom service call `patchUser` that allows updating specific fields of a user object instead of sending the entire object. The `partialUserShape` is introduced to define the shape of the partial user object. Code changes: - Added `partialUserShape` to `user/models.ts` - Added `patchUser` custom service call to `userApi` in `user/api.ts`
This commit adds a warning alert in the EditProfile screen to inform users about the permanent nature of account deletion. The alert provides a cancel option and a delete option, allowing users to make an informed decision. The alert is triggered when the user taps on the delete button. Code changes: - Added warning alert for account deletion in EditProfile screen
lakardion
previously approved these changes
Aug 30, 2024
{{cookiecutter.project_slug}}/clients/mobile/react-native/src/screens/settings/edit-profile.tsx
Outdated
Show resolved
Hide resolved
{{cookiecutter.project_slug}}/clients/mobile/react-native/src/screens/settings/edit-profile.tsx
Outdated
Show resolved
Hide resolved
{{cookiecutter.project_slug}}/clients/mobile/react-native/src/services/user/api.ts
Outdated
Show resolved
Hide resolved
{{cookiecutter.project_slug}}/clients/mobile/react-native/src/services/user/hooks.ts
Outdated
Show resolved
Hide resolved
{{cookiecutter.project_slug}}/clients/mobile/react-native/src/services/user/models.ts
Outdated
Show resolved
Hide resolved
whusterj
previously approved these changes
Aug 30, 2024
There was a problem hiding this comment.
All checks are passing now! I think this is good to go if @lakardion signs off.
|
These checks are still showing up, and I'm not sure why: 
|
|
@lakardion - Did you want to see changes made before merging, or can I go ahead and merge this in? |
The patchUser service call in the user API is no longer used and can be safely removed. This commit removes the patchUser service call from the user API file. Code changes: - Removed patchUser service call in user API
This commit adds the useAuth hook to the EditProfile screen in order to retrieve the userId. The userId is used to retrieve the user's full name and display it in the EditProfile screen. This improves the user experience by pre-filling the full name input field with the user's current full name. Code changes: - Added useAuth hook to retrieve userId - Pre-filled full name input field with user's current full name
This commit updates the import statements for user hooks in the user service file. The import paths have been changed to reflect the new file structure. This ensures that the user hooks are correctly imported and used in the user service. Code changes: - Updated import paths for user hooks in user service
@whusterj could it be a required check configured on the repo itself? |
lakardion
approved these changes
Aug 30, 2024
Just made them to be gone. They were being required from Settings in the branch protection rules. Added playwright instead
Ah yeah I approved since the comments weren't that big but Edwin fixed them I just reapproved! This should be good to go |
|
Awesome - thanks to you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Add a description of what feature/page this PR intends to add or change.
Checklist
How to test