-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Multiple Notifiables #95
base: master
Are you sure you want to change the base?
Add Multiple Notifiables #95
Conversation
@thomasjohnkane package dead? |
@atymic will this be merged ever or not? |
Could you bring this up to date and add some tests to ensure no BC breaks please? |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #95 +/- ##
============================================
- Coverage 96.42% 87.66% -8.77%
- Complexity 88 97 +9
============================================
Files 10 10
Lines 280 308 +28
============================================
Hits 270 270
- Misses 10 38 +28 ☔ View full report in Codecov by Sentry. |
@atymic it's been 2 years 😅... but I updated the original PR description, there is a new method as for the Breaking change, I think there will be none as this just introduces the new |
Hi,
i was raised an issue #94 using my other account @aneesdev.. i made this pr to be able to create many scheduled notifications just like laravel Notification facade. so there is
createMany
method for multiple notifiables.