Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor iOS Core navigation and Update Screens #377

Merged
merged 82 commits into from
Dec 23, 2024
Merged

Refactor iOS Core navigation and Update Screens #377

merged 82 commits into from
Dec 23, 2024

Conversation

thomaskioko
Copy link
Owner

@thomaskioko thomaskioko commented Dec 23, 2024 •
edited
Loading

Description

This PR brings a vast improvement to the iOS code, improving the snapiness of the iOS app. This also updates some of the components used to a more native look and feel. The changes span multiple modules and include iOS and shared code implementations.

Some new elements and screens have been added as placeholders and will be implemented in later PRs.

Key Changes (iOS)

  • Improved lifecycle management.
  • Replaced the custom Tab with the native iOS Tab.
  • Refactored SwiftUI views to have a native look and feel.
  • Improve Image memory management. Drop down the memory consumption from 1.4GB to around 130MB, give or take. Commit 🤯 There's some caching improvement to be done but, I will tackle this later.
  • Updated theme handling and UI styling

Other changes.

  • Added a new Genre data layer with repository pattern implementation.
  • Introduced ShowGenre model and related database tables.
  • Updated database schema to support many-to-many relationships between shows and genres.
  • Cleaned up Store mapper extensions. (I think I was high when I implemented that bit) 😵‍💫

Known Issues.

  • Navigating back using the back button from ShowDetails to HomeTab shows a blank screen.

Demo

iOSDemoApp.mov

Screen Rework.

  • Home Tab
  • Discover Tab
  • Settings Tab
  • Search Tab
  • Watchlist Tab
  • Season Details
  • Show Details.
  • Watch More
  • Profile

closes #339

@thomaskioko
Replace deprecated animation function.
36935d6
@thomaskioko
Move class to TvManiacKit
1e17706
@thomaskioko
Move class to App Directory
e1a24be
@thomaskioko
Move view to SplashScreen Directory
39eb689
@thomaskioko
Use extension function.
88c8f65
@thomaskioko
Re-write navigation stack implementation and remove custom navigation…
204424a 
… animation.
@thomaskioko
Remove KSP plugin.
0eaae41
@thomaskioko
Enable configuration-cache.parallel
d78e50e
@thomaskioko
Fix color background for SettingsView
6dc757c
@thomaskioko
Move RootView to Root dir.
9760ce7
@thomaskioko
Added proper lifecycle management in iOSApp using SwiftUI's scenePhase.
b71400a
@thomaskioko
Minor refactor on the views.
f39e180
@thomaskioko
Create new tab screen UI views.
5c82e1a
@thomaskioko
Add extension functions.
ec7eb96
@thomaskioko
Minor refactor.
22b8807 
- Convert Value to StateFlow.
- Rename some classes & variables.
@thomaskioko
Replace type alias with class
4bdfd43
@thomaskioko
Split Home presenter to interface and implementation.
3bf8053
@thomaskioko
Create new components. DecomposeNavigationView and KotlinStateFlow
7424233
@thomaskioko
Create TabContentView that implements iOS' native Tab bar
78ca2b1
@thomaskioko
Use correct component after renaming shared code.
c2329a7
@thomaskioko
Create new RootNavigationView that add the new views and update iOS a…
a66bdd0 
…pp to use it..
@thomaskioko
Add show overview to show object.
fe922c9
@thomaskioko
Add action to update show library state.
38e2ab6
@thomaskioko
Add navigationBarTitle.
9262695
@thomaskioko
Implement Carousel and add Parallax view.
63104cf 
- Make the UI feel more native. The header view inspiration is from AppleTV+ application.
@thomaskioko
Implement custom navigation bar and a smoother reveal/hide animation.
57b81f7
@thomaskioko
Update UI
e1b47c7 
- Move Show info and indicator to discover view. This allows us to make the info scroll above the image.
- Smooth out CarouselView animation.
@thomaskioko
Update CarouselView and make it generic.
7f67f8e 
- This gives us more control of the content view and makes the the view reusable.
- Fix issue with item not being update to correct state. When clicking on the plus icon, view was not being updated correctly.
@thomaskioko
Cleanup database module structure.
ce250f6 
- Move adapter classes to adapter module.
- Create Factory class for creating the database object. This moves it out or the component class.
@thomaskioko
Cleanup
46b9822 
- Move model classes to model package and update imports.
@thomaskioko
Fix shows not being synced when adding shows in quick succession.
fe2cff8
@thomaskioko
Update theming implementation and make it more dynamic.
8127960
@thomaskioko
Update views to use the device's theme to set the colors.
f25245e
@thomaskioko
Refactor ParallaxView and simplify it's implementation.
e03dca5
@thomaskioko
Minor cleanup and remove nested stacks.
35d10db
@thomaskioko
Add ShowDetails and SeasonDetails view.
14993ec
@thomaskioko
Fix overview box and when we hide and show Show More text.
30e91ae
@thomaskioko
Minor UI fix on header views.
f8acb1f
@thomaskioko
Delete ParallaxHeader and use ParallaxView in DiscoverTab
c506d05
@thomaskioko
Improve state handling and prevent the app from showing a blank scree…
0367dd4 
…n for a few seconds.
@thomaskioko
Remember carousel position when navigating to a different screen
2e1958d
@thomaskioko
Swift UI component update.
49b7985 
- Update GlassToolbar to center the title and add theming.
- Improve states in season details and show details screen.
- Update title fonts and colors.
- Fix some padding issues.
@thomaskioko
Update iOS Demo
c691724
@thomaskioko
Update snapshot tests.
fc56698
@thomaskioko
Move mapper extensions to TvManiac kit.
3275869
@thomaskioko
Update database scheme and fix failing test
1103344
@thomaskioko thomaskioko added ios iOS related task/issue improvement Fix or improvement of an existing feature labels Dec 23, 2024
@thomaskioko thomaskioko force-pushed the ios-improvements branch 7 times, most recently from ba4f4b4 to d2933fc Compare December 23, 2024 16:38
@thomaskioko
Comment out fastlane job.
35ec84d 
- Todo: fix fastlane failure
@thomaskioko thomaskioko merged commit 5693733 into main Dec 23, 2024
@thomaskioko thomaskioko deleted the ios-improvements branch December 23, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
improvement Fix or improvement of an existing feature ios iOS related task/issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(iOS) Fix Navigation Lag
1 participant
@thomaskioko