encode_colour accepts a list besides a matrix #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request lets
encode_colour()
accept a list or a data frame instead of a colour matrix.This has performance improvements when each channel is computed independently, because instead of
cbind()
-ing them together we canlist()
them, avoiding the allocation of a larger matrix.This is a first subset of #35, aiming to improve performance in farver with larger vectors. It is part of tidyverse/ggplot2#4989, to improve the performance of rasterizing large matrices.
No breaking changes are introduced.
Each commit can be reviewed independently.
Thanks for your time