Handle error even if the logger is nil (#72)

thomaspoignant · Mar 29, 2021 · c101f1a · c101f1a
1 parent a045071
commit c101f1a
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/internal/notifier/notifier_webhook.go b/internal/notifier/notifier_webhook.go
@@ -63,8 +63,10 @@ func (c *WebhookNotifier) Notify(diff model.DiffCache, wg *sync.WaitGroup) {
 	}
 	response, err := c.HTTPClient.Do(&request)
 	// Log if something went wrong while calling the webhook.
-	if err != nil && c.Logger != nil {
-		c.Logger.Printf("[%v] error: while calling webhook: %v\n", date, err)
+	if err != nil {
+		if c.Logger != nil {
+			c.Logger.Printf("[%v] error: while calling webhook: %v\n", date, err)
+		}
 		return
 	}
 	defer response.Body.Close()