Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing $ in templates #122

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Add missing $ in templates #122

merged 1 commit into from
Sep 29, 2023

Conversation

thomiceli
Copy link
Owner

Should fix #116

@thomiceli
Copy link
Owner Author

@Aetherinox if possible, would you mind building the project from the branch (just run make) and tell me if you still have the 502 bad gateway error with your repository ?

@Aetherinox
Copy link

Aetherinox commented Sep 28, 2023

Sure, if you can give me just a quick series of steps. I've never ran from a different branch and not sure of the steps considering I have the existing version installed using docker.

Edit: I found your make instructions in readme, installed go, and the other stuff. Just nodejs 16+ is being a pain. The ubuntu 22 WSL2 I installed came with 12. And upgrading to 16 is being an absolute pain.

@Aetherinox
Copy link

Aetherinox commented Sep 29, 2023

What a pain that was, I hate WSL2 and the way IPs work.

Yes, revisions seem to work great.

kJM3gKm

Sorry it took so long, Nodejs on Ubuntu 22 defaults to v12. It doesn't like upgrading to 16 so I had to wipe all packages and then do a fresh install.

Don't worry about the missing $. I've developed for years. Thanks to long nights I've done crap that is so astronomically dumb, I've contemplated my life choices.

@thomiceli
Copy link
Owner Author

Perfect, thanks again

@thomiceli thomiceli merged commit d137820 into master Sep 29, 2023
8 checks passed
@thomiceli thomiceli deleted the fix/templates-dollar branch September 29, 2023 04:32
@Aetherinox
Copy link

Aetherinox commented Sep 29, 2023

@thomiceli Just tested v1.5.1, revisions works great now on production server. Thanks.

I got Pihole and Opengist operating properly in the same day. I feel like it's Christmas.

jiriks74 pushed a commit to jiriks74/opengist that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking gist "Revisions" tab causing 502 Bad Gateway
2 participants