Merge pull request #50 from iharthi/fix/abort-signal-polyfilled

Fix AbortSignal issue in after minification
thorgate · Mar 4, 2019 · be095e5 · be095e5
2 parents 950fb84 + 7376a91
commit be095e5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/packages/is/src/index.ts b/packages/is/src/index.ts
@@ -41,11 +41,17 @@ export const isStatusCode = (statusCodes: number | number[], status: any): statu
 
 export const isAbortSignal = (signal: any): signal is AbortSignal => {
     const proto = (
-        signal
+        !!signal
         && typeof signal === 'object'
         && Object.getPrototypeOf(signal)
     );
-    return !!(proto && proto.constructor.name === 'AbortSignal');
+    // Fail-safe fallback, is required to work with some browsers that do not have native implementation of AbortSignal
+    const isCompatible = (
+        !!signal
+        && typeof signal.aborted !== 'undefined'
+        && typeof signal.onabort !== 'undefined'
+    );
+    return !!(proto && proto.constructor.name === 'AbortSignal') || isCompatible;
 };
 
 

diff --git a/packages/is/test/typeChecks.test.ts b/packages/is/test/typeChecks.test.ts
@@ -213,5 +213,6 @@ describe('typeChecks api', () => {
 
         }
         expect(isAbortSignal(new AbortSignal())).toEqual(true);
+        expect(isAbortSignal({ aborted: false, onabort: null, listeners: {} })).toEqual(true);
     });
 });
-Original file line number
+Diff line change
@@ Expand Up / @@ -213,5 +213,6 @@ describe('typeChecks api', () => { @@
             }
             expect(isAbortSignal(new AbortSignal())).toEqual(true);
+            expect(isAbortSignal({ aborted: false, onabort: null, listeners: {} })).toEqual(true);
         });
     });