IM6 (PFLOTRAN alquimia coupling) #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsulman
commented
Jun 5, 2024
bsulman
commented
Jun 7, 2024
Comment on lines
2968
to
2981
| <entry id="ELM_USE_PFLOTRAN"> | ||
| <type>logical</type> | ||
| <valid_values>TRUE,FALSE</valid_values> | ||
| <default_value>FALSE</default_value> | ||
| <group>build_component_clm</group> | ||
| <file>env_build.xml</file> | ||
| <desc>TRUE implies ELM is built with support for coupling to PFLOTRAN | ||
| through the PFLOTRAN interface. PFLOTRAN | ||
| uses the PETSc library. In order to use PFLOTRAN, CLM | ||
| must be built with PETSc support and linking to PETSc must occur | ||
| when building the ACME executable. This occurs if this variable | ||
| is set to TRUE. Note that is only available on a limited set of | ||
| machines/compilers.</desc> | ||
| </entry> |
There was a problem hiding this comment.
I'm not sure this is used for Alquimia...
bsulman
commented
Jul 11, 2024
There was a problem hiding this comment.
I get a message Deprecated "arg" node detected in /home/b0u/cases/Alaska_alquimia_test_AK-BEO_ICB1850CNRDCTCBC/env_batch.xml, check files /home/b0u/models/E3SM-NGEE/cime_config/machines/config_batch.xml when doing create_newcase on cades. Has the format of this xml changed?
Update cmake on cades
bsulman
commented
Oct 7, 2024
Comment on lines
+2423
to
+2453
| if(actual_dt<=60.0_r8) then | ||
| ! write(iulog,*),'Alquimia: Time step cut to 60 s. Attempting to solve by pausing transport and solving layer by layer' | ||
| do j=1,nlevdecomp | ||
| ! Update properties from ELM | ||
| this%chem_state%porosity = porosity(j) | ||
| this%chem_state%temperature = temperature(j) - 273.15 | ||
| this%chem_properties%volume = volume(j) | ||
| this%chem_properties%saturation = sat(j) ! Set minimum saturation to stop concentrations from blowing up at low soil moisture | ||
| call this%copy_ELM_to_Alquimia(j,water_density,& | ||
| aqueous_pressure,& | ||
| total_mobile,& | ||
| total_immobile,& | ||
| mineral_volume_fraction,& | ||
| mineral_specific_surface_area,& | ||
| surface_site_density,& | ||
| cation_exchange_capacity,& | ||
| aux_doubles,& | ||
| aux_ints) | ||
| call run_onestep(this,dt,num_cuts,ncuts) | ||
| call this%copy_Alquimia_to_ELM(j,water_density_tmp,& | ||
| aqueous_pressure_tmp,& | ||
| total_mobile_tmp,free_mobile_tmp,& | ||
| total_immobile_tmp,& | ||
| mineral_volume_fraction_tmp,& | ||
| mineral_specific_surface_area_tmp,& | ||
| surface_site_density_tmp,& | ||
| cation_exchange_capacity_tmp,& | ||
| aux_doubles_tmp,& | ||
| aux_ints_tmp) | ||
| enddo | ||
| endif |
There was a problem hiding this comment.
I think we should remove this block (the if actual_dt<60). I'm not sure it's in the right place and it's usually not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code and configuration changes to enable coupling of E3SM to PFLOTRAN via the alquimia interface and EMI