Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix organization names to string in prescription template #148

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

mayaCostantini
Copy link
Contributor

Related Issues and Dependencies

Related to thoth-station/prescriptions#22413

This introduces a breaking change

  • No

This should yield a new module release

  • No

This Pull Request implements

Force string type in prescription template for organization, repository and package names.

@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 25, 2022
Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this will pass pre-commit checks.

@codificat
Copy link
Member

It did pass pre-commit checks
/approve

@sesheta
Copy link
Member

sesheta commented Apr 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codificat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2022
@sesheta sesheta merged commit 437a94a into thoth-station:master Apr 27, 2022
@fridex
Copy link
Contributor

fridex commented Apr 27, 2022

It did pass pre-commit checks

I meant in the prescriptions repository. It has configured double quotes without possible redundancy. We might make these checks weaker then.

@codificat
Copy link
Member

I meant in the prescriptions repository.

Oh! Of course! 🤦 my apologies

It has configured double quotes without possible redundancy. We might make these checks weaker then.

You are right, the changes cause pre-commit's yamllint to fail when the quotes are applied to strings, e.g. (sample quick test):

yamllint.................................................................Failed
- hook id: yamllint
- exit code: 1

prescriptions/zo_/zope/gh_release_notes.yaml
  10:17     error    string value is redundantly quoted with double quotes  (quoted-strings)
  13:23     error    string value is redundantly quoted with double quotes  (quoted-strings)
  14:21     error    string value is redundantly quoted with double quotes  (quoted-strings)

I will send a revert for this.

@mayaCostantini mayaCostantini deleted the fix-organization-str branch May 4, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants