Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to scorecards prescriptions #177

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

mayaCostantini
Copy link
Contributor

Related Issues and Dependencies

Related to open-services-group/scrum#28 and thoth-station/core#434

This introduces a breaking change

  • No

This should yield a new module release

  • Yes

This Pull Request implements

Add tags to Scorecards prescriptions for easier processing.

@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 29, 2022
@sesheta sesheta added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 29, 2022
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2022
@sesheta
Copy link
Member

sesheta commented Jul 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2022
@sesheta sesheta merged commit 7db7811 into thoth-station:master Jul 29, 2022
@mayaCostantini mayaCostantini deleted the tag-scorecards branch July 29, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants