Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate setup.py to pyproject.toml (#8) #10

Conversation

ChandanChainani
Copy link
Contributor

Related Issues and Dependencies

Fixes #8

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

… Explain your changes.

Description

@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 20, 2022
@ChandanChainani ChandanChainani force-pushed the feature/8/setup.py_to_pyproject.toml branch from 29a971c to 57ec808 Compare October 22, 2022 16:58
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks 💯

@sesheta sesheta added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 25, 2022
@sesheta sesheta removed the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2022
@ChandanChainani ChandanChainani requested review from harshad16 and removed request for mayaCostantini October 26, 2022 13:52
@harshad16
Copy link
Member

/ok-to-test

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thank you for your contribution 100

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2022
@sesheta
Copy link
Member

sesheta commented Nov 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codificat codificat mentioned this pull request Dec 13, 2022
@codificat
Copy link
Member

/retest

@sesheta sesheta merged commit d844765 into thoth-station:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to pyproject.toml
4 participants