Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call PyEval_InitThreads() on Python 3.7+ #132

Merged
merged 3 commits into from
May 31, 2024
Merged

Don't call PyEval_InitThreads() on Python 3.7+ #132

merged 3 commits into from
May 31, 2024

Conversation

vstinner
Copy link
Contributor

Since Python 3.7, the function does nothing. Moreover, it's deprecated since Python 3.9:
https://docs.python.org/3.12/c-api/init.html#c.PyEval_InitThreads

thp
thp requested changes Apr 24, 2024
View reviewed changes
Copy link
Owner

@thp thp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With #131 bumping the minimum version to Python 3.8 (3.7 was EOL'd 2023-06-27), I think we can just remove PyEval_InitThreads(). If you could also add an entry to the changelog in docs/index.rst, that'd be great :)

@vstinner
Remove PyEval_InitThreads() call
d45bf29 
Since Python 3.7, the function does nothing. Moreover, it's
deprecated since Python 3.9:
https://docs.python.org/3.12/c-api/init.html#c.PyEval_InitThreads

Since pyotherside requires Python 3.8, simply remove the call.
@vstinner vstinner force-pushed the eval_init_threads branch from 4f8cb18 to d45bf29 Compare May 23, 2024 17:04
@vstinner
Copy link
Contributor Author

With #131 bumping the minimum version to Python 3.8 (3.7 was EOL'd 2023-06-27), I think we can just remove PyEval_InitThreads(). If you could also add an entry to the changelog in docs/index.rst, that'd be great :)

Done. Would you mind to review the updated PR?

thp
thp approved these changes May 31, 2024
View reviewed changes
Copy link
Owner

@thp thp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thp thp merged commit 4fa3406 into thp:master May 31, 2024
3 checks passed
@vstinner vstinner deleted the eval_init_threads branch May 31, 2024 06:45
@vstinner
Copy link
Contributor Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thp thp thp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @thp