Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iss#841 adjust activation-service workflow #844

Conversation

sameh-farouk
Copy link
Member

@sameh-farouk sameh-farouk commented Aug 3, 2023

What's changed:

  • Move the workflow to root .github/workflows/
  • Specify the subdirectory as the context
  • Adjust image name to ghcr.io/threefoldtech/tfchain_activation_service

This workflow should triggered on publish release, and for a release like v1.0.0 , it will build and push the activation-service image to ghcr.io/threefoldtech/tfchain_activation_service and tag it with 1.0.0 tag.

Related Issues:
#841

@sameh-farouk sameh-farouk changed the title feat: adjust activation-service workflow fix: iss#841 adjust activation-service workflow Aug 3, 2023
Copy link
Contributor

@robvanmieghem robvanmieghem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@brandonpille brandonpille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@sameh-farouk sameh-farouk merged commit 6d20312 into development Aug 7, 2023
1 check passed
@sameh-farouk sameh-farouk deleted the development-fix-tfchain-activation-service-workflow branch August 7, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants