Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Threema::Receive::DeliveryReceipt class #40

Merged
merged 6 commits into from
May 9, 2024
Merged

Improve Threema::Receive::DeliveryReceipt class #40

merged 6 commits into from
May 9, 2024

Conversation

mattwr18
Copy link
Collaborator

actually return the processed information useful to know which delivery receipt is being delivered and for which message(s)

Closes #39

@mattwr18 mattwr18 mentioned this pull request Apr 27, 2024
Merged
roschaefer
roschaefer requested changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@roschaefer roschaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done

After a while it's quite easy to understand what's going on. I would like to get these things cleared up and then it's ready to get merged! 💪

lib/threema/receive/delivery_receipt.rb Show resolved Hide resolved
lib/threema/receive/delivery_receipt.rb Outdated Show resolved Hide resolved
lib/threema/receive/delivery_receipt.rb Outdated Show resolved Hide resolved
lib/threema/receive/delivery_receipt.rb Outdated Show resolved Hide resolved
lib/threema/receive/delivery_receipt.rb Outdated Show resolved Hide resolved
spec/threema/receive/delivery_receipt_spec.rb Show resolved Hide resolved
spec/threema/receive/delivery_receipt_spec.rb Outdated Show resolved Hide resolved
spec/threema/receive/delivery_receipt_spec.rb Show resolved Hide resolved
spec/threema/receive/delivery_receipt_spec.rb Outdated Show resolved Hide resolved
lib/threema/receive/delivery_receipt.rb Outdated Show resolved Hide resolved
roschaefer
roschaefer approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@roschaefer roschaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!
good to go

@mattwr18 mattwr18 merged commit 40477ef into master May 9, 2024
2 checks passed
@mattwr18 mattwr18 deleted the 39_improve_delivery_receipt_class branch May 9, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roschaefer roschaefer roschaefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[improvement] Improve Threema::Receive::DeliveryReceipt Class
2 participants
@mattwr18 @roschaefer