Loosen restrictions on activesupport gem #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roschaefer as discussed, I'll merge this in... If you get a free minute, feel free to take a look. |
roschaefer
reviewed
May 23, 2024
There was a problem hiding this comment.
So, I had a look at this and I'm confused. I just git pulled on master and I ran bundle install. I see the following:
$ bundle
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Fetching activesupport 7.0.8 (was 7.0.8.1)
Installing activesupport 7.0.8 (was 7.0.8.1)
Fetching factory_bot 6.4.6 (was 6.1.0)
Installing factory_bot 6.4.6 (was 6.1.0)
Bundle complete! 10 Gemfile dependencies, 47 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
So effectively, activesupport got downgraded. If this fixes a problem, good. But maybe we want to allow newer versions of activesupport, too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43