[Add] Auth ldap async #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
February 7, 2018 21:23
…ame and password to thread context
|
@farvour can you rebase your PR? Current master is support modern gcc's. |
|
Resolve #66 |
|
Any news on this? |
|
After 2 weeks of debugging and tries to find a root cause of packet loss/high latency when using openvpn I came to this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dirty implementation of using POSIX threads to invoke the deferred authentication plugin call for the OpenVPN LDAP Auth plugin.
Issue:
When a connection is initiated to OpenVPN, the authentication runs on the main thread, which means slow LDAP servers, LDAP proxies (e.g. using DUO 2Factor Auth etc) that hang or wait will block all traffic in and out of the VPN.
Solution:
Use a thread and defer the call taking advantage of OpenVPN 2.3.14+'s v2 implementation hook and write to the acf file.
Caveats:
I didn't work to make this backward compatible with older Objective-C (non-modern) runtime, so it requires CentOS 7+ (gcc 4.6 and up?). If someone else wants to add all of the conditionals / changes to do that please feel free!
Disclaimer:
My ObjC and C strengths are not very strong, and I made the best what I could with the solution. It solves the problem in our application of it and that is what I was shooting for.