Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Solidity API docs #36

Merged
merged 7 commits into from
Jun 29, 2023
Merged

Update Solidity API docs #36

merged 7 commits into from
Jun 29, 2023

Conversation

thesis-valkyrie
Copy link
Contributor

Copy link
Member

@pdyraga pdyraga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some non-blocking comments, I'll try to address them in a follow-up PR.

Comment on lines +3 to +4
You can learn about APIs of contracts related to the Random Beacon under the
following links:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This copy could be a bit better. We could point the reader to the repository, say that the code documentation was generated automatically based on the docs in the code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#37

You can learn about APIs of contracts related to the Random Beacon under the
following links:

[AltBn128](./generated-docs/libraries/AltBn128.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to have them as a bullet list?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question to all README.md files in this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#37

@pdyraga pdyraga merged commit 8036f2c into main Jun 29, 2023
@pdyraga pdyraga deleted the auto-update-solidity-api-docs branch June 29, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants