-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ledger live implementation #515
Commits on May 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 37d51a7 - Browse repository at this point
Copy the full SHA 37d51a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4da9032 - Browse repository at this point
Copy the full SHA 4da9032View commit details -
Configuration menu - View commit details
-
Copy full SHA for 42d139b - Browse repository at this point
Copy the full SHA 42d139bView commit details -
Fix typings in ledger_live connector
and also remove unnecessary `IFrameEthereumProvider` import
Configuration menu - View commit details
-
Copy full SHA for 27053bc - Browse repository at this point
Copy the full SHA 27053bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b1eff2 - Browse repository at this point
Copy the full SHA 9b1eff2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2a1af9 - Browse repository at this point
Copy the full SHA d2a1af9View commit details
Commits on May 17, 2023
-
For both dark mode and light mode.
Configuration menu - View commit details
-
Copy full SHA for f7be6fa - Browse repository at this point
Copy the full SHA f7be6faView commit details -
Adds four listeners to the ledger live procider: - networkChanged - chainChanged - accountsChanged - close Also removes them in `deactivate` method.
Configuration menu - View commit details
-
Copy full SHA for 131ab84 - Browse repository at this point
Copy the full SHA 131ab84View commit details -
Fix error then disconnectin the Ledger wallet.
There was an error which happened after clicking `Disconnect` while being connected with a Ledger wallet. To fix that we simply remove the `this.provider = undefined` line form the `deactivate` method as it is not necessary.
Configuration menu - View commit details
-
Copy full SHA for 740de82 - Browse repository at this point
Copy the full SHA 740de82View commit details
Commits on May 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d7ed01b - Browse repository at this point
Copy the full SHA d7ed01bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 869f9ac - Browse repository at this point
Copy the full SHA 869f9acView commit details
Commits on May 30, 2023
-
We call `activate` method in the `WalletConnectionModalBase` already.
Configuration menu - View commit details
-
Copy full SHA for f936566 - Browse repository at this point
Copy the full SHA f936566View commit details -
Configuration menu - View commit details
-
Copy full SHA for c235c98 - Browse repository at this point
Copy the full SHA c235c98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1149fa5 - Browse repository at this point
Copy the full SHA 1149fa5View commit details -
The `provider` is already marked as `optional` so we don't have to type it as possibly undefined.
Configuration menu - View commit details
-
Copy full SHA for f1fac17 - Browse repository at this point
Copy the full SHA f1fac17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36b0767 - Browse repository at this point
Copy the full SHA 36b0767View commit details
Commits on Jun 5, 2023
-
Close walletconnection modal for LedgerLive
We should close Wallet Connection modal when activating the provider of LedgerLive, because it will open it's own modal.
Configuration menu - View commit details
-
Copy full SHA for 6ccab86 - Browse repository at this point
Copy the full SHA 6ccab86View commit details
Commits on Jun 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 225800e - Browse repository at this point
Copy the full SHA 225800eView commit details
Commits on Jun 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6f909fc - Browse repository at this point
Copy the full SHA 6f909fcView commit details
Commits on Jun 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for bc69060 - Browse repository at this point
Copy the full SHA bc69060View commit details
Commits on Jun 12, 2023
-
Add alert for unsupported network
Here we are adding the alert for unsupported networks when connecting to LedgerLive. For this I had to remove the try catch block from `activate` method so that the error can be catched outside of the ledger connection in `WalletConnectionModalBase`. We pass the `onError` method to the `activate` method as a second argument and this way we can set the `web3React` error which then is read by our `WalletConnectionAlert` component.
Configuration menu - View commit details
-
Copy full SHA for f6ff7f5 - Browse repository at this point
Copy the full SHA f6ff7f5View commit details
Commits on Jul 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for eaaa1b6 - Browse repository at this point
Copy the full SHA eaaa1b6View commit details -
Update @ledgerhq/connect-kit-loader lib
Update `@ledgerhq/connect-kit-loader` lib to `1.1.0`. This will add support to connecting ledger live using wallet connect v2.
Configuration menu - View commit details
-
Copy full SHA for df848ca - Browse repository at this point
Copy the full SHA df848caView commit details -
Adjust
checkSupport
method for new lib versionAdjust `connectKit.checkSupport` method for the new version of `@ledgerhq/connect-kit-loader`.
Configuration menu - View commit details
-
Copy full SHA for 66224b1 - Browse repository at this point
Copy the full SHA 66224b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for aaacbe7 - Browse repository at this point
Copy the full SHA aaacbe7View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab114c9 - Browse repository at this point
Copy the full SHA ab114c9View commit details
Commits on Jul 25, 2023
-
Add
shouldForceCloseModal
propertyAdds `shouldForceCloseModal` property to `WalletConnectionModalBase` component.
Configuration menu - View commit details
-
Copy full SHA for 3bf7da1 - Browse repository at this point
Copy the full SHA 3bf7da1View commit details
Commits on Jul 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 98a6086 - Browse repository at this point
Copy the full SHA 98a6086View commit details
Commits on Jul 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e3f46f9 - Browse repository at this point
Copy the full SHA e3f46f9View commit details -
Pass project id through a constructor
Pass wallet connect project id through ledger live constructor.
Configuration menu - View commit details
-
Copy full SHA for 0853ce8 - Browse repository at this point
Copy the full SHA 0853ce8View commit details
Commits on Aug 11, 2023
-
Update
@ledgerhq/connect-kit-loader
Update `@ledgerhq/connect-kit-loader` lib to 1.1.2.
Configuration menu - View commit details
-
Copy full SHA for 1f996cd - Browse repository at this point
Copy the full SHA 1f996cdView commit details
Commits on Aug 14, 2023
-
Fix "Cannot convert undefined or null to object"
Sometime there is an error "Cannot convert undefined or null to object" when trying to connect to walletconnect or ledger live. To reproduce it (before the fix in this commit of course) you should: 1. Connect through Ledger Live 2. Disconnect 3. Connect through Ledger Live again (with the same account) 4. Disconnect 5. Connect through WalletConnect (it should automatically connect with the same account that you used while connecting to Ledger Live) 6. Disconnect 7. Connect again through Ledger Live 8. The error should appear The similar issue was descibed here: WalletConnect/walletconnect-monorepo#3165 This commit fixes that issue by clearing out the local storage from the walleconnect realted data.
Configuration menu - View commit details
-
Copy full SHA for 6cfe182 - Browse repository at this point
Copy the full SHA 6cfe182View commit details