Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger live implementation #515

Merged
merged 32 commits into from
Aug 16, 2023
Merged

Ledger live implementation #515

merged 32 commits into from
Aug 16, 2023

Commits on May 15, 2023

  1. Add Ledger Live connector

    Create a Ledger Live connector
    michalsmiarowski committed May 15, 2023
    Configuration menu
    Copy the full SHA
    37d51a7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4da9032 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    42d139b View commit details
    Browse the repository at this point in the history
  4. Fix typings in ledger_live connector

    and also remove unnecessary `IFrameEthereumProvider` import
    michalsmiarowski committed May 15, 2023
    Configuration menu
    Copy the full SHA
    27053bc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9b1eff2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d2a1af9 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Add proper Ledger Live icon

    For both dark mode and light mode.
    michalsmiarowski committed May 17, 2023
    Configuration menu
    Copy the full SHA
    f7be6fa View commit details
    Browse the repository at this point in the history
  2. Add listeners to the provider

    Adds four listeners to the ledger live procider:
    - networkChanged
    - chainChanged
    - accountsChanged
    - close
    
    Also removes them in `deactivate` method.
    michalsmiarowski committed May 17, 2023
    Configuration menu
    Copy the full SHA
    131ab84 View commit details
    Browse the repository at this point in the history
  3. Fix error then disconnectin the Ledger wallet.

    There was an error which happened after clicking `Disconnect` while being
    connected with a Ledger wallet. To fix that we simply remove the
    `this.provider = undefined`
    line form the `deactivate` method as it is not necessary.
    michalsmiarowski committed May 17, 2023
    Configuration menu
    Copy the full SHA
    740de82 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Configuration menu
    Copy the full SHA
    d7ed01b View commit details
    Browse the repository at this point in the history
  2. Add empty line

    michalsmiarowski committed May 25, 2023
    Configuration menu
    Copy the full SHA
    869f9ac View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Remove duplicated code

    We call `activate` method in the `WalletConnectionModalBase` already.
    michalsmiarowski committed May 30, 2023
    Configuration menu
    Copy the full SHA
    f936566 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c235c98 View commit details
    Browse the repository at this point in the history
  3. Rename ledger_live connector

    ledger_live -> ledgerLive
    michalsmiarowski committed May 30, 2023
    Configuration menu
    Copy the full SHA
    1149fa5 View commit details
    Browse the repository at this point in the history
  4. Remove unnecessary undefined.

    The `provider` is already marked as `optional` so we don't have to type it as
    possibly undefined.
    michalsmiarowski committed May 30, 2023
    Configuration menu
    Copy the full SHA
    f1fac17 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    36b0767 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Close walletconnection modal for LedgerLive

    We should close Wallet Connection modal when activating the provider of
    LedgerLive, because it will open it's own modal.
    michalsmiarowski committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    6ccab86 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Configuration menu
    Copy the full SHA
    225800e View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Configuration menu
    Copy the full SHA
    6f909fc View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Configuration menu
    Copy the full SHA
    bc69060 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Add alert for unsupported network

    Here we are adding the alert for unsupported networks when connecting to
    LedgerLive. For this I had to remove the try catch block from `activate` method
    so that the error can be catched outside of the ledger connection in
    `WalletConnectionModalBase`. We pass the `onError` method to the `activate`
    method as a second argument and this way we can set the `web3React` error which
    then is read by our `WalletConnectionAlert` component.
    michalsmiarowski committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    f6ff7f5 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Configuration menu
    Copy the full SHA
    eaaa1b6 View commit details
    Browse the repository at this point in the history
  2. Update @ledgerhq/connect-kit-loader lib

    Update `@ledgerhq/connect-kit-loader` lib to `1.1.0`. This will add support to
    connecting ledger live using wallet connect v2.
    michalsmiarowski committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    df848ca View commit details
    Browse the repository at this point in the history
  3. Adjust checkSupport method for new lib version

    Adjust `connectKit.checkSupport` method for the new version of
    `@ledgerhq/connect-kit-loader`.
    michalsmiarowski committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    66224b1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    aaacbe7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ab114c9 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Add shouldForceCloseModal property

    Adds `shouldForceCloseModal` property to `WalletConnectionModalBase` component.
    michalsmiarowski committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    3bf7da1 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Configuration menu
    Copy the full SHA
    98a6086 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Configuration menu
    Copy the full SHA
    e3f46f9 View commit details
    Browse the repository at this point in the history
  2. Pass project id through a constructor

    Pass wallet connect project id through ledger live constructor.
    michalsmiarowski committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    0853ce8 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Update @ledgerhq/connect-kit-loader

    Update `@ledgerhq/connect-kit-loader` lib to 1.1.2.
    michalsmiarowski committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    1f996cd View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Fix "Cannot convert undefined or null to object"

    Sometime there is an error "Cannot convert undefined or null to object"
    when trying to connect to walletconnect or ledger live. To reproduce it
    (before the fix in this commit of course) you should:
    1. Connect through Ledger Live
    2. Disconnect
    3. Connect through Ledger Live again (with the same account)
    4. Disconnect
    5. Connect through WalletConnect (it should automatically connect with
    the same account that you used while connecting to Ledger Live)
    6. Disconnect
    7. Connect again through Ledger Live
    8. The error should appear
    
    The similar issue was descibed here: WalletConnect/walletconnect-monorepo#3165
    
    This commit fixes that issue by clearing out the local storage from the
    walleconnect realted data.
    michalsmiarowski committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    6cfe182 View commit details
    Browse the repository at this point in the history