Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with Link Overlay in tBTC Explorer #556

Merged
merged 1 commit into from
Jul 25, 2023

Commits on Jun 26, 2023

  1. Fix issue with Link Overlay in tBTC Explorer

    We encountered an issue with the <LinkOverlay> component from chakra-ui while
    using it in the History table on the tBTC Explorer page. This component was
    intended to facilitate navigation for each row, directing the user to the
    corresponding etherscan link. However, we noticed an abnormal behavior
    specifically on real mobile devices, even though it worked correctly in the
    mobile view on Chrome.
    
    On mobile, the overlay for the last item appeared to cover the entire page. As a
    result, any other links on the tBTC Explorer page, such as "View on Dune
    Analytics" or "Start Minting," unintentionally redirected the user to etherscan.
    
    The cause of this was that the `LinkBox` component uses `position: relative` to
    contain the absolute positioned `LinkOverlay`.  Unfortunately `<Tr />`
    component, which we passed to the `as property, does not allow `position:
    relative`.
    
    As a hacky workaround we are applying `transform: scale(1)` to the tr element.
    michalsmiarowski committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    5bb9bbb View commit details
    Browse the repository at this point in the history