Fix isValidBtcAddress function
#577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass correct value to the `validate` function from `bitcoin-address-validation` package. The `toBcoinNetwork` function from `tbtc-v2.ts` lib returns the network as string expected by the `bcoin` lib(meaning `main` or `testnet`). The `bitcoin-address-validation` package expects `mainnet` or `testnet` that match the enumerated `BitcoinNetwork` values from `tbtc-v2.ts` lib. Here we call `valuesOf` on the `BitcoinNetwork` enum to get the expected network as string by the `bitcoin-address-validation` package.
lukasz-zimnoch
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass correct value to the
validatefunction frombitcoin-address-validationpackage. ThetoBcoinNetworkfunction fromtbtc-v2.tslib returns the network as string expected by thebcoinlib(meaningmainortestnet). Thebitcoin-address-validationpackage expectsmainnetortestnetthat match the enumeratedBitcoinNetworkvalues fromtbtc-v2.tslib. Here we callvaluesOfon theBitcoinNetworkenum to get the expected network as string by thebitcoin-address-validationpackage.