[Backport] Redemption improvements #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We encountered an issue with the <LinkOverlay> component from chakra-ui while using it in the History table on the tBTC Explorer page. This component was intended to facilitate navigation for each row, directing the user to the corresponding etherscan link. However, we noticed an abnormal behavior specifically on real mobile devices, even though it worked correctly in the mobile view on Chrome. On mobile, the overlay for the last item appeared to cover the entire page. As a result, any other links on the tBTC Explorer page, such as "View on Dune Analytics" or "Start Minting," unintentionally redirected the user to etherscan. The cause of this was that the `LinkBox` component uses `position: relative` to contain the absolute positioned `LinkOverlay`. Unfortunately `<Tr />` component, which we passed to the `as property, does not allow `position: relative`. As a hacky workaround we are applying `transform: scale(1)` to the tr element.
Currently 3 hours is quite optimistic and it often takes around 5 hours (experienced that during UATs several times). Here we update a copy saying that a redemption takes `3-5 hours`.
The Elapsed Time should be a dynamic countdown. Here we update the elapsed time every one minute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of: #556
Backport of: #580
Backport of: #582
Backport of: #583
This PR fixes typos, improves the elapsed time counter and updates copy on the Unmint page.