Improve UX in redemption details page #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redirect to a success step when the redemption is complete. Here we subscribe to the `RedemptionsCompleted` event and check if this event is related to a given redemption request by checking the wallet public key hash. If yes, we are looking for a Bitcoin transfer to a given redeemer output script in a given bitcoin tx hash (we can get this transaction hash from the `RedemptionsCompleted` event). If we are able to find that transfer it means this `RedemptionsCompleted` events is related to a given redemption request and we should redirect user to a success step.
Fix condition to render the check mark icon correctly in the redemption process timeline once the redemption process is complete.
Update the bridge activity array in a store when the redemption process is complete. We should change the status of a given redemption to `unminted`.
michalsmiarowski
requested changes
Sep 5, 2023
This way we we will reduce the occurences of the `redemptionBitcoinTransfer` in code which makes it easier in case we would like to rename that variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirect a user to a success step automatically when the redemption is complete. Here we subscribe to the
RedemptionsCompletedevent and check if this event is related to a given redemption request by checking the wallet public key hash. If yes, we are looking for a Bitcoin transfer to a given redeemer output script in a given bitcoin tx hash (we can get this transaction hash from theRedemptionsCompletedevent). If we are able to find that transfer it means thisRedemptionsCompletedevent is related to a given redemption request and we should redirect user to a success step and update the bridge activity list.