Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a possibility to reveal multiple transactions #600

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

michalsmiarowski
Copy link
Contributor

Add a possibility to reveal multiple transactions send to the same BTC deposit address. In such case the user should use /tBTC/mint/continue url to initiate the minting of each subsequent transaction after he revealed the first one.

Add a possibility to reveal multiple transactions send to the same BTC deposit
address. In such case the user should use `/tBTC/mint/continue` url to initiate
the minting of each subsequent transaction after he revealed the first one.
@github-actions
Copy link

Copy link
Collaborator

@r-czajkowski r-czajkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two minor comments. Overall LGTM.

src/store/tbtc/effects.ts Outdated Show resolved Hide resolved
src/store/tbtc/effects.ts Outdated Show resolved Hide resolved
Improve comment that describes how we search for the oldest UTXO that is not
revealed.
@github-actions
Copy link

@michalsmiarowski michalsmiarowski self-assigned this Sep 6, 2023
@michalsmiarowski michalsmiarowski marked this pull request as ready for review September 7, 2023 12:31
@michalsmiarowski michalsmiarowski added this to the v1.10.0 milestone Sep 7, 2023
@r-czajkowski r-czajkowski merged commit 21b6d35 into main Sep 7, 2023
5 checks passed
@r-czajkowski r-czajkowski deleted the allow-revealing-multiple-deposits branch September 7, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants