Fix update handler validation #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
michalsmiarowski
requested changes
Jul 26, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A bug was identified when connecting WalletConnect to Gnosis Safe via the wc pairing API: Shortly after a user connects their Gnosis Safe vault to the app, the connection was disconnected.
Upon investigation, it was discovered that the connection between WalletConnect and Gnosis Safe was being interrupted due to the chainId format generated after connecting to Gnosis Safe. This triggered an update that disrupted the connection because of the way the update validation was structured in App.tsx.
Depending on the format in which the chainId is being passed by a 3rd party service, it may trigger an update. To handle these edge cases, this PR aims to add a more comprehensive validation method similarly to what has already been done previously in the commit @3ca72b93ca72b9.
Type of change
Notice
Issue (if applicable)
closes #768
Pull Request Type