Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessible name for contact picture checkbox #8694

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

williamspiegel
Copy link

Fixes #8446 for the most part, but announcing the checked state seems to mostly be already handled by the "X selected" announcement. Maybe need some clarification about what needs to be changed there if that is still considered an issue. This PR only handles the issue with the checkbox itself being unlabeled.

@dankeck
Copy link

dankeck commented Jan 5, 2025

Thanks for working on this and for adding the checkbox labeling. Hopefully I can clarify the other part of my issue.

It's true that, with some effort, a user could determine the current state of the checkbox by toggling it and listening to the "X selected" announcement, to see if X goes up or down. If X goes up, then the checkbox went from unchecked to checked. If X goes down, then the checkbox went from checked to unchecked.

But this constitutes extra steps for users with disabilities. It'd be great if landing on a checkbox could announce its current state right away.

In HTML, native checkboxes have this behavior by default. For custom-built checkboxes in HTML, an attribute named aria-checked is added to tell screen readers to announce the current state. But I don't know what an analog would be in Android code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants