use check_param()

tidymodels · Dec 1, 2023 · b275bd1 · b275bd1
1 parent de32db1
commit b275bd1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 13 deletions.
diff --git a/R/aaa_values.R b/R/aaa_values.R
@@ -312,9 +312,7 @@ value_set <- function(object, values) {
   if (length(values) == 0) {
     rlang::abort("`values` should at least one element.")
   }
-  if (!inherits(object, "param")) {
-    rlang::abort("`object` should be a 'param' object")
-  }
+  check_param(object)
 
   if (inherits(object, "quant_param")) {
     object <-

diff --git a/R/finalize.R b/R/finalize.R
@@ -152,9 +152,7 @@ finalize.default <- function(object, x, force = TRUE, ...) {
 #' @export
 #' @rdname finalize
 get_p <- function(object, x, log_vals = FALSE, ...) {
-  if (!inherits(object, "param")) {
-    rlang::abort("`object` should be a 'param' object.")
-  }
+  check_param(object)
 
   rngs <- range_get(object, original = FALSE)
   if (!is_unknown(rngs$upper)) {
@@ -188,9 +186,8 @@ get_log_p <- function(object, x, ...) {
 #' @export
 #' @rdname finalize
 get_n_frac <- function(object, x, log_vals = FALSE, frac = 1/3, ...) {
-  if (!inherits(object, "param")) {
-    cli::cli_abort("{.arg object} should be a {.cls param} object.")
-  }
+  check_param(object)
+
   rngs <- range_get(object, original = FALSE)
   if (!is_unknown(rngs$upper)) {
     return(object)

diff --git a/tests/testthat/_snaps/finalize.md b/tests/testthat/_snaps/finalize.md
@@ -4,15 +4,15 @@
       get_p(1:10)
     Condition
       Error in `get_p()`:
-      ! `object` should be a 'param' object.
+      ! `object` must be a single parameter object, not an integer vector.
 
 ---
 
     Code
       get_p(1:10, 1:10)
     Condition
       Error in `get_p()`:
-      ! `object` should be a 'param' object.
+      ! `object` must be a single parameter object, not an integer vector.
 
 ---
 
@@ -28,15 +28,15 @@
       get_n(1:10)
     Condition
       Error in `get_n_frac()`:
-      ! `object` should be a <param> object.
+      ! `object` must be a single parameter object, not an integer vector.
 
 ---
 
     Code
       get_n(1:10, 1:10)
     Condition
       Error in `get_n_frac()`:
-      ! `object` should be a <param> object.
+      ! `object` must be a single parameter object, not an integer vector.
 
 ---