some missing snapshots #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfrick
approved these changes
Dec 16, 2024
| Code | ||
| grid_max_entropy(mixture(), levels = 11) | ||
| Condition | ||
| Warning: |
There was a problem hiding this comment.
This warning should either be an error right away, or if we really want people to be able to continue with this mix-up, we should remove the stray argument so it doesn't interfer like it does here, causing an error later on with a surprising error message. This applies to all other grid functions with this type of warning as well. I'll turn it into a separate issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filling in some blanks to get coverage to approximately 97.95%.
Some remaining lines may not be reachable.