Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs for fit_best() #713

Merged
merged 1 commit into from
Aug 23, 2023
Merged

docs for fit_best() #713

merged 1 commit into from
Aug 23, 2023

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Aug 21, 2023

This PR removes a sentence about validation sets which is not true anymore (instead we now have the add_validation_set argument to specify the behaviour).

It would be awesome to include this change in #707 🙏

@hfrick hfrick merged commit 0dda348 into main Aug 23, 2023
9 checks passed
@hfrick hfrick deleted the doc-fit-best-validation-set branch August 23, 2023 08:04
EmilHvitfeldt added a commit that referenced this pull request Aug 23, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants