refactor compute_grid_info()
#957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topepo
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
These changes make a lot of sense; we over-engineered the code that generates the grid tasks early on.
I've tested this in a few different scenarios today and don't see any issues.
Also, I would not worry about the column order; I doubt that we are calling by order instead of name (and shame on us if we do 😄 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
compute_grid_info()to set the stage for postprocessing. Instead of having one function perhas_preprocessor x has_model x has_postprocessorcombination, simplifies to one code path.Related to #948, where I made sure to test thoroughly that these changes would have no effect on output. The column ordering does indeed change, but this object never makes it to users and we always subset it by name internally.