-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Geom aesthetics based on theme (#5833)
* draft new `geom` element in themes * plumbing for providing theme to Geom$use_defaults() * make `from_theme()` as eval helper * Evaluate default aesthetics from theme * allow user-specified `from_theme()` * plumbing for guides to observe theme * Add text settings * accept minor fontsize difference (11.04pt -> 11.00pt) * temporarily disable `sf_grob()` default lookups * temporary shim for colour mixing * Get all `colour`/`fill`/`linewidth` from theme * test theme has `geom` element * adapt tests * `geom_sf()` has themed defaults * we don't expect complete themes anymore * shim auto-replaces itself when exported from scales * theme defaults for point size/shape * boxplot point shape/size default from `GeomBoxplot$default_aes` * accept larger points in large theme snapshots * Point to theme setting in `update_geom_defaults()` * document `from_theme()` * add news bullet * Update R/geom-pointrange.R Co-authored-by: Thomas Lin Pedersen <thomasp85@gmail.com> * Run revdepcheck * implement @yutannihilation's suggestion * run revdepcheck * revdepcheck once again * protect against missing `theme` * skip empty sf layers * getter for geom defaults * add `linetype` to `element_geom()` * `geom_path()` treats integer `1L` as solid (in addition to numeric `1`) * get linetype from theme * swap thin/thick for linewidth/borderwidth and distinguish linetype and bordertype * point stroke counts as border * deduplicate argument documentation --------- Co-authored-by: Thomas Lin Pedersen <thomasp85@gmail.com>
- Loading branch information
Showing
75 changed files
with
6,029 additions
and
7,277 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.