Skip to content

Commit

Permalink
Merge pull request #5380 from tidyverse/v3.4.3-rc
Browse files Browse the repository at this point in the history
Release 3.4.3
  • Loading branch information
thomasp85 committed Aug 15, 2023
2 parents 2cd0e96 + 62a5f4a commit 8af03a9
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 76 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Package: ggplot2
Version: 3.4.2.9000
Version: 3.4.3.9000
Title: Create Elegant Data Visualisations Using the Grammar of Graphics
Authors@R: c(
person("Hadley", "Wickham", , "hadley@posit.co", role = "aut",
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,10 @@
duplicated coordinates (@teunbrand, #5215).
* Improve performance of layers without positional scales (@zeehio, #4990)

# ggplot2 3.4.3
This hotfix release addresses a version comparison change in r-devel. There are
no user-facing or breaking changes.

# ggplot2 3.4.2
This is a hotfix release anticipating changes in r-devel, but folds in upkeep
changes and a few bug fixes as well.
Expand Down
4 changes: 2 additions & 2 deletions R/backports.R
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Backport fix from R 3.3:
# https://github.com/wch/r-source/commit/4efc81c98d262f93de9e7911aaa910f5c63cd00f
if (getRversion() < 3.3) {
if (getRversion() < "3.3") {
absolute.units <- getFromNamespace("absolute.units", "grid")
absolute.units.unit <- getFromNamespace("absolute.units.unit", "grid")
absolute.units.unit.list <- getFromNamespace("absolute.units.unit.list", "grid")
Expand All @@ -18,6 +18,6 @@ if (getRversion() < 3.3) {
on_load(backport_unit_methods())

# isFALSE() is available on R (>=3.5)
if (getRversion() < 3.5) {
if (getRversion() < "3.5") {
isFALSE <- function(x) is.logical(x) && length(x) == 1L && !is.na(x) && !x
}
78 changes: 5 additions & 73 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,73 +1,5 @@
This is a patch release responding to a request from CRAN about new warnings in
R-devel. It also includes a small batch of of bug fixes since last release.
There are no user facing changes.

All breaking reverse dependencies have been notified.

## revdepcheck results

We checked 4503 reverse dependencies (4468 from CRAN + 35 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.

* We saw 8 new problems
* We failed to check 29 packages

Issues with CRAN packages are summarised below.

### New problems
(This reports the first line of each new failure)

* afex
checking re-building of vignette outputs ... WARNING

* dalmatian
checking re-building of vignette outputs ... WARNING

* DriveML
checking re-building of vignette outputs ... WARNING

* EcoEnsemble
checking re-building of vignette outputs ... WARNING

* ggtern
checking Rd files ... WARNING

* siland
checking re-building of vignette outputs ... WARNING

* TCIU
checking re-building of vignette outputs ... WARNING

* xpose
checking tests ... ERROR

### Failed to check

* beadplexr (NA)
* CausalImpact (NA)
* CensMFM (NA)
* cinaR (NA)
* ctsem (NA)
* genekitr (NA)
* ggh4x (NA)
* glmmPen (NA)
* grandR (NA)
* immcp (NA)
* loon.ggplot (NA)
* MACP (NA)
* MarketMatching (NA)
* MARVEL (NA)
* nlmixr2rpt (NA)
* numbat (NA)
* OlinkAnalyze (NA)
* OpenMx (NA)
* Platypus (NA)
* PsychWordVec (NA)
* RcppCensSpatial (NA)
* rstan (NA)
* RVA (NA)
* rxode2 (NA)
* SCpubr (NA)
* tidySEM (NA)
* tinyarray (NA)
* valse (NA)
* vivid (NA)
This is a patch release responding to a request from CRAN about numeric
version comparisons in R-devel. It also includes a workaround for changes
in the `stats::density()` function in R-devel that affected visual tests.
There are no user facing changes, so no reverse dependencies are expected to
be affected.

0 comments on commit 8af03a9

Please sign in to comment.