Use na.rm parameter in StatBoxplot (#3556)

tidyverse · Oct 7, 2019 · a2ab197 · a2ab197
1 parent 1895864
commit a2ab197
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/R/stat-boxplot.r b/R/stat-boxplot.r
@@ -51,7 +51,7 @@ StatBoxplot <- ggproto("StatBoxplot", Stat,
     data$x <- data$x %||% 0
     data <- remove_missing(
       data,
-      na.rm = FALSE,
+      na.rm = params$na.rm,
       vars = "x",
       name = "stat_boxplot"
     )

diff --git a/tests/testthat/test-stat-boxplot.R b/tests/testthat/test-stat-boxplot.R
@@ -19,3 +19,11 @@ test_that("stat_boxplot drops missing rows with a warning", {
     "Removed 10 rows containing missing values \\(stat_boxplot\\)\\."
   )
 })
+
+test_that("stat_boxplot can suppress warning about missing rows", {
+  p1 <- ggplot(PlantGrowth, aes(x = group, y = weight)) +
+    geom_boxplot(position = "dodge", na.rm = TRUE) +
+    scale_x_discrete(limits = c("trt1", "ctrl"))
+
+  expect_silent(ggplot_build(p1))
+})