-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Improve extending ggplot2 vignette? #5590
Labels
Milestone
Comments
Guide extensions are covered in #5693 |
Looking good! thanks for taking good care of noobs :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://ggplot2.tidyverse.org/dev/articles/extending-ggplot2.html
Maybe it could have a little section about the new guides improvements?
I think it should mention
dropped_aes
? I am not sure I did this correctly, but in tidyquant, I made these edits to silence those warnings.business-science/tidyquant#242
Also, the current example in the vignette seems to involve a deprecated function.
ggproto docs
Also, maybe the ggproto
...
could be improved a little? Currently, it only says "list of members", maybe it could be a little more precise and point to the correct place.https://ggplot2.tidyverse.org/dev/reference/ggproto.html?q=ggproto#arguments
Thanks
The text was updated successfully, but these errors were encountered: