Adopt suggestions of #5590 #5721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
commented
Feb 28, 2024
Comment on lines
+30
to
+36
| #' @section Working with ggproto classes: | ||
| #' The ggproto objects constructed are build on top of environments, which has | ||
| #' some ramifications. Environments do not follow the 'copy on modify' semantics | ||
| #' one might be accustomed to in regular objects. Instead they have | ||
| #' ['modify in place'](https://adv-r.hadley.nz/names-values.html#env-modify) | ||
| #' semantics. | ||
| #' |
There was a problem hiding this comment.
I added this bit of my own volition, because I recall being a bit stumped by this when first working with ggproto objects.
Merge branch 'main' into fix_5590 # Conflicts: # R/ggproto.R # R/stat-.R
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5590.
Briefly, it adopts some of the suggestions raised in the issue.