Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF: Let the gradient scales handle missing values #5034

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zeehio
Copy link
Contributor

@zeehio zeehio commented Nov 6, 2022

The last PR related to:

Depends on:

Provides a performance improvement with:

This pull request passes the na.value colour to the palette in scale_colour_gradient() and friends. This is useful if the two pull requests above get merged, because it will let ggplot2 skip checking for missing values after mapping values to colours (the palette will have already replaced them)

It would require to update the scales version dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant