PERF: Let the gradient scales handle missing values #5034
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last PR related to:
Depends on:
Provides a performance improvement with:
This pull request passes the
na.value
colour to the palette inscale_colour_gradient()
and friends. This is useful if the two pull requests above get merged, because it will let ggplot2 skip checking for missing values after mapping values to colours (the palette will have already replaced them)It would require to update the scales version dependency