Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve layer documentation #5127

Merged
merged 9 commits into from
Feb 27, 2024
Merged

Improve layer documentation #5127

merged 9 commits into from
Feb 27, 2024

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #4770, fix #5040 and fix #4606.

Briefly, it does the following things:

  • It makes 3 standalone documented topics for the layer geom, layer stat and layer position arguments.
  • It expands the description of these arguments in layer() and links them to the standalone topics.
  • The ... argument to geom_*() and stat_*() functions is now more explicit about what it accepts and rejects.

Merge branch 'main' into layer_docs

# Conflicts:
#	DESCRIPTION
#	R/geom-bin2d.R
#	R/geom-boxplot.R
#	R/geom-count.R
#	R/geom-hex.R
#	R/geom-text.R
#	R/geom-violin.R
#	man/geom_hex.Rd
#	man/geom_text.Rd
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 1b60839 into tidyverse:main Feb 27, 2024
12 checks passed
@teunbrand teunbrand deleted the layer_docs branch February 27, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants