Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert size -> linewidth in annotation_logticks() #5330

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Convert size -> linewidth in annotation_logticks() #5330

merged 2 commits into from
Aug 7, 2023

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #5292.

Briefly, it updates annotation_logticks() to use linewidth instead of size.
Using size now gives a deprecation message.

@teunbrand teunbrand added layers 📈 bug an unexpected problem or unintended behavior labels Jul 9, 2023
thomasp85
thomasp85 approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit bde88f8 into tidyverse:main Aug 7, 2023
12 checks passed
@teunbrand teunbrand deleted the annotation_logticks_linewidth branch August 7, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
bug an unexpected problem or unintended behavior layers 📈
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

size is used in annotation_logticks() instead of linewidth
2 participants
@teunbrand @thomasp85