Avoid theme partial string matching #5335
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #2724.
Briefly, it replaces most instances of
theme$setting
withcalc_element("setting", theme)
.A particularly gnarly case was
guide_legend()
that overrides inheritance, but I've tried to use double-bracket indexing in such cases. Also updated vignette with this, hopefully encouraging people to usecalc_element()
instead.