Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider linewidth in legend key sizes #5346

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #5160.

Briefly, key size is now determined by size + linewidth instead of just size.

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit da2a8e8 into tidyverse:main Aug 7, 2023
9 of 10 checks passed
@teunbrand teunbrand deleted the key_linewidth branch August 7, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linewidth not considered in legend key sizing
2 participants